Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #267 - Show activities dropdown labels with regular user #268

Merged
merged 1 commit into from Jun 7, 2023
Merged

Fix #267 - Show activities dropdown labels with regular user #268

merged 1 commit into from Jun 7, 2023

Conversation

azzy9
Copy link
Contributor

@azzy9 azzy9 commented May 25, 2023

Description

Includes activities modules language file into the extra modules so regular users can see the labels for the dropdown.

Motivation and Context

Fix issue #267

How To Test This

Before change:
regular user cannot see labels in activities subpanel dropdown as seen in #267

After change:
The issue is fixed

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • [x ] My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • [x ] I have read the How to Contribute guidelines.

@jack7anderson7 jack7anderson7 added Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Requires Code Review labels May 31, 2023
Copy link
Contributor

@clemente-raposo clemente-raposo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clemente-raposo clemente-raposo merged commit e706a19 into salesagility:hotfix Jun 7, 2023
1 check passed
@azzy9 azzy9 deleted the Hotfix-Activities branch June 8, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Passed Code Review Status: Passed Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants