Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AOR_Reports - main group sql query sanitizing #1206

Closed
jellydonuts opened this issue Apr 5, 2016 · 1 comment
Closed

AOR_Reports - main group sql query sanitizing #1206

jellydonuts opened this issue Apr 5, 2016 · 1 comment
Assignees
Labels
Priority:Critical Issues & PRs that are critical; broken core functionality, fatal errors - there are no workarounds Type:Bug Bugs within the core SuiteCRM codebase

Comments

@jellydonuts
Copy link

Noticed that if you create a report where you reference a field as the main group and that field contains certain control characters (like a single quote), the character makes it through all the way to the sql query and results in funky behaviour.

Eg main group set to name of account, one of the account names is "Mary's". This group will show in the results but all of the results will be missing because the sql select where clause is "where name is 'Mary's'... "

@mattlorimer mattlorimer added Type:Bug Bugs within the core SuiteCRM codebase Priority:Critical Issues & PRs that are critical; broken core functionality, fatal errors - there are no workarounds labels Apr 5, 2016
gymad added a commit that referenced this issue Apr 6, 2016
fixed #1206 - AOR_Reports - main group sql query sanitizing
@jellydonuts
Copy link
Author

Still not 100% fixed... the functionality works, but now the main group's name is escaped... see attached picture.

still not fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Critical Issues & PRs that are critical; broken core functionality, fatal errors - there are no workarounds Type:Bug Bugs within the core SuiteCRM codebase
Projects
None yet
Development

No branches or pull requests

4 participants