Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong API key max length #2413

Closed
svalo opened this issue Oct 13, 2016 · 0 comments
Closed

Wrong API key max length #2413

svalo opened this issue Oct 13, 2016 · 0 comments
Labels
Priority:Critical Issues & PRs that are critical; broken core functionality, fatal errors - there are no workarounds Status:Fix Proposed A issue that has a PR related to it that provides a possible resolution Type:Bug Bugs within the core SuiteCRM codebase

Comments

@svalo
Copy link

svalo commented Oct 13, 2016

Issue

Max lenght of the API key decrlared here is 32 while an api key generated yesterday is 39 characters long

Expected Behavior

I should be able to insert an API key 39 chars long

Actual Behavior

When I copy the value it gets truncated at 32chars

Possible Fix

in modules/jjwg_Maps/views/view.config.php

--- view.config.php.old 2016-10-13 11:01:27.527122395 +0200
+++ view.config.php     2016-10-13 11:01:40.313948901 +0200
@@ -420,7 +420,7 @@
             value="<?php echo (isset($GLOBALS['jjwg_config']['geocoding_api_secret'])) ?
                 htmlspecialchars($GLOBALS['jjwg_config']['geocoding_api_secret']) :
                 htmlspecialchars($GLOBALS['jjwg_config_defaults']['geocoding_api_secret']); ?>"
-            title='' tabindex='140' size="25" maxlength="32">
+            title='' tabindex='140' size="25" maxlength="39">
             &nbsp; <?php echo $GLOBALS['mod_strings']['LBL_CONFIG_DEFAULT']; ?>
                 <?php echo htmlspecialchars($GLOBALS['jjwg_config_defaults']['geocoding_api_secret']) ?>
         </td>

Steps to Reproduce

  1. Go to Admin -> Google Maps setting -> Secret Phrase for Proxy:
  2. Try to insert a value longer than 32

Your Environment

  • SuiteCRM Version used: 7.t.5
  • Browser name and version (e.g. Chrome Version 51.0.2704.63 (64-bit)): Qupzilla and Firefox both latest version on ArchLinux
  • Environment name and version (e.g. MySQL, PHP 7): Mysql, PHP5, Nginx
  • Operating System and version (e.g Ubuntu 16.04): Ubuntu 14.04
@ijdavie ijdavie added Type:Bug Bugs within the core SuiteCRM codebase Priority:Critical Issues & PRs that are critical; broken core functionality, fatal errors - there are no workarounds labels Oct 17, 2016
shogunpol pushed a commit to shogunpol/SuiteCRM that referenced this issue Nov 2, 2016
@shogunpol shogunpol added the Status:Fix Proposed A issue that has a PR related to it that provides a possible resolution label Nov 2, 2016
samus-aran added a commit that referenced this issue Nov 12, 2016
fixed - #2413 Wrong API key max length
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Critical Issues & PRs that are critical; broken core functionality, fatal errors - there are no workarounds Status:Fix Proposed A issue that has a PR related to it that provides a possible resolution Type:Bug Bugs within the core SuiteCRM codebase
Projects
None yet
Development

No branches or pull requests

6 participants