Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.8.15 undefined labels in quote item lines #5255

Closed
boombata opened this issue Feb 19, 2018 · 16 comments
Closed

7.8.15 undefined labels in quote item lines #5255

boombata opened this issue Feb 19, 2018 · 16 comments
Labels
Priority:Moderate Issues & PRs that are minor; broken styling, cosmetic, warnings - there are practical workarounds Type: Bug Bugs within the core SuiteCRM codebase

Comments

@boombata
Copy link
Contributor

Issue

upgraded from 7.8.8 to 7.8.15 , now when creating a quote, the labels in lint items are "undefined"

Expected Behavior

correct labels should be displayed

Actual Behavior

see attached screenshot

Possible Fix

Steps to Reproduce

  1. create a quote
    2.add a group
    3.add product line

Context

Your Environment

  • SuiteCRM Version used:
  • Browser name and version (e.g. Chrome Version 51.0.2704.63 (64-bit)):
  • Environment name and version (e.g. MySQL, PHP 7): 7
  • Operating System and version (e.g Ubuntu 16.04): ubuntu 16.04
    undefined labels
@e-reeley
Copy link
Contributor

Hi @boombata

Sorry to see this, I'm just going to make a couple checks to help us see what is causing this issue.

Would you be able to ensure that you run the following in the crm:

  1. Repair and Rebuild
  2. Repair htaccess file

Both found in the admin and repair file.

Thanks for reporting the issue.

@boombata
Copy link
Contributor Author

Hi @e-reeley
yes both repairs have been run.
thank you.

@e-reeley
Copy link
Contributor

@boombata

Thats good, has that helped at all or are we still in the same issue? :)

Thanks.

@boombata
Copy link
Contributor Author

sorry no help, problem still persists :)

@e-reeley
Copy link
Contributor

Okay, ill take a look into this :) Ill keep you posted!

Thanks again.

@e-reeley
Copy link
Contributor

I downloaded a fresh install of 7.8.8, upgraded to 7.8.15 and this does not seem to be an issue for me.

Was it okay before the upgrade? :)

Thanks.

@boombata
Copy link
Contributor Author

yes

@boombata
Copy link
Contributor Author

tried a JS language rebuild but did not help. i'm going through the logs to find something revelent.

@e-reeley
Copy link
Contributor

Perfect, anything that can maybe put us on the right line or maybe try and spot why my instance is different.

Thanks.

@boombata
Copy link
Contributor Author

cannot find anything from the logs, it is like the jslanguage cache is not received by the browser (if i understood how it works) in the quote only the line items do no have labels, all other parts of the quote is ok including group label.

@boombata
Copy link
Contributor Author

boombata commented Feb 20, 2018

yesterday i forget to say that i already re-applied chmod and chown like specified in installation doc followed by a quick repair and rebuild but it did not help

@boombata
Copy link
Contributor Author

@e-reeley , still having undefined labels in quotes lines items,

What i did so far

  • Set the following permissions on the SuiteCRM directory(Linux):

    sudo chown -R www-data:www-data .
    sudo chmod -R 755 .
    sudo chmod -R 775 cache custom modules themes data upload config_override.php

  • .htaccess rebuild, (is is set with: RewriteBase /)

  • quick repair and rebuild
    -Rebuild Javascript Languages

  • cleared browser cache (also tried from other pc and navigators)

  • used navigator debuger and confirmed it get data to https://crm.mydomain.com/cache/jsLanguage/en_us.js?v=BYrfiJ2bM90xSDUXVDWBfg (i changed the variable to past it here)

  • in the answer from en_us.js?v=BYrfiJ2bM90xSDUXVDWBfg there is no "add service" nor "add product" translations.

  • i deleted /cache/jsLanguage/en_us.js re recreate it, but did not help.

  • looked at upgrade log, no error reported.

  • run first step of upgrade wizzard to check if all files files permission are well set, all is ok.

not sure if it could be linked but, I have some custom fields in the quote modules and custom en_us.lang.js for AOS_Quotes containing only the new fields translations. these fields were added from studio last year.

do you have other ideas while i continue my investigations ?

Thank you very much.

@boombata
Copy link
Contributor Author

boombata commented Feb 20, 2018

@e-reeley it's fixed !!

there is a problem with this #5141

the rebuild htaccess file is adding 2 mod_rewrite.c to .htaccess see attached file. (or keeping the one you add before upgrade)

in the first one the rewrite parameter got "module" parameter but in the second it send "modulename"
parameter as expected by the PR 5141.
htaccess.txt

deleted the first one with "module" parameter (the one outside BEGIN SUGARCRM RESTRICTIONS)
run quick repair.
Cleared browser cache

@e-reeley
Copy link
Contributor

Hi @boombata

Sorry for the late response, Im happy to hear that you managed to spot the issue :D

It now seems to be behaving as it should?

Thanks again for raising the issue and helping with a solution to this issue.

@boombata
Copy link
Contributor Author

Hi @e-reeley

Yes it is behaving as it should now.

It could be good to rework modules\Administration\UpgradeAccess.php to remove mod.rewrite.c from old content (line 88).

Thanks for your help.

@Dillon-Brown Dillon-Brown added Type: Bug Bugs within the core SuiteCRM codebase Priority:Moderate Issues & PRs that are minor; broken styling, cosmetic, warnings - there are practical workarounds labels Feb 23, 2018
@hubyhuby
Copy link

hubyhuby commented Apr 16, 2018

Hi there,
I upgraded from 7.8.11 to 7.8.18 and I still get this issue.
Is it supposed to be solved? What is next release ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Moderate Issues & PRs that are minor; broken styling, cosmetic, warnings - there are practical workarounds Type: Bug Bugs within the core SuiteCRM codebase
Projects
None yet
Development

No branches or pull requests

5 participants