Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused string LBL_SUGARCRM_HELP - Hotfix branch #5359

Closed
horus68 opened this issue Feb 28, 2018 · 0 comments
Closed

Unused string LBL_SUGARCRM_HELP - Hotfix branch #5359

horus68 opened this issue Feb 28, 2018 · 0 comments
Assignees
@Dillon-Brown
Labels
Area: Language Issues & PRs that are confirmed as issues with language & translation within the core Status:Fix Proposed A issue that has a PR related to it that provides a possible resolution

Comments

@horus68
Copy link
Contributor

horus68 commented Feb 28, 2018

Issue

Unused string 'LBL_SUGARCRM_HELP' => 'SuiteCRM Help'
from modules/Administration/language/en_us.lang.php used in

  • modules/Administration/SupportPortal.tpl
  • modules/Administration/SupportPortal.php

See: https://github.com/salesagility/SuiteCRM/search?utf8=%E2%9C%93&q=LBL_SUGARCRM_HELP&type=

This should be removed from hotfix branch due to removal of the SupportPortal code files in 58ff71e

Possible Fix

Remove string

Context

Unused strings and to cut down on Sugar!

Your Environment

  • SuiteCRM Version used: Hotfix branch
@Dillon-Brown Dillon-Brown added the Area: Language Issues & PRs that are confirmed as issues with language & translation within the core label Feb 28, 2018
@Dillon-Brown Dillon-Brown self-assigned this Mar 9, 2018
@Dillon-Brown Dillon-Brown added the Status:Fix Proposed A issue that has a PR related to it that provides a possible resolution label Mar 12, 2018
@Dillon-Brown Dillon-Brown mentioned this issue Mar 12, 2018
Merged
6 tasks
samus-aran added a commit that referenced this issue Mar 13, 2018
@samus-aran
Merge pull request #5486 from Dillon-Brown/issue-5359
546fb4d 
Fixed #5359 - Unused string LBL_SUGARCRM_HELP - Hotfix branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dillon-Brown Dillon-Brown

Labels
Area: Language Issues & PRs that are confirmed as issues with language & translation within the core Status:Fix Proposed A issue that has a PR related to it that provides a possible resolution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@horus68 @samus-aran @Dillon-Brown @Mac-Rae