Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong JS File referenced in Contacts DetailViewDefs #5613

Closed
jshwhitlow opened this issue Mar 27, 2018 · 1 comment
Closed

Wrong JS File referenced in Contacts DetailViewDefs #5613

jshwhitlow opened this issue Mar 27, 2018 · 1 comment
Labels
Priority:Important Issues & PRs that are important; broken functions, errors - there are workarounds Status:Fix Proposed A issue that has a PR related to it that provides a possible resolution Type: Bug Bugs within the core SuiteCRM codebase

Comments

@jshwhitlow
Copy link

Issue

Wrong file is referenced in modules/Contacts/metadata/detailviewdefs.php on line 151

Currently it says:

'includes' => 
      array (
        0 => 
        array (
          'file' => 'modules/Leads/Lead.js',
        ),
      ),

Expected Behavior

It should say:

'includes' => 
      array (
        0 => 
        array (
          'file' => 'modules/Contacts/Contact.js',
        ),
      ),

Actual Behavior

Wrong JS file is loaded

Possible Fix

'includes' => 
      array (
        0 => 
        array (
          'file' => 'modules/Contacts/Contact.js',
        ),
      ),

Steps to Reproduce

  1. Navigate to modules/Contacts/metadata/detailviewdefs.php on line 151
  2. Look at code

Context

I was making some changes in my custom detailviewdefs.php and noticed that, I went back to ensure it wasn't just my instance and saw it was a SuiteCRM bug.

Your Environment

  • SuiteCRM Version used: 7.10.1
  • Browser name and version: 65.0.3325.181 64-bit
  • Environment name and version: MySQL 5.7, PHP 7.1.12
  • Operating System and version: macOS Sierra 10.12.3
@PedroErnst
Copy link
Contributor

PedroErnst commented Mar 28, 2018

@jshwhitlow

Thank you, nice find.

@Dillon-Brown Dillon-Brown added Type: Bug Bugs within the core SuiteCRM codebase Status:Fix Proposed A issue that has a PR related to it that provides a possible resolution Priority:Important Issues & PRs that are important; broken functions, errors - there are workarounds Resolved: Next Release labels Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Important Issues & PRs that are important; broken functions, errors - there are workarounds Status:Fix Proposed A issue that has a PR related to it that provides a possible resolution Type: Bug Bugs within the core SuiteCRM codebase
Projects
None yet
Development

No branches or pull requests

4 participants