Document Attachment Subpanel link incorrect

[markbond1007]

Issue

When uploading documents as linked/related to other objects (ie Accounts), the download link in the subpanel is incorrect.

The link is like this:

http://suitecrm.icestarmedia.com/index.php?entryPoint=download&id=d72b597a-429a-61e4-0930-5bf3e8d8c6f9&type=Accounts

prior to the updated to 7.10.10 the link was like this:
https://crm.workingoptions.co.uk/index.php?preview=yes&entryPoint=download&id=2912e3c6-ada0-7a64-6658-5bdc70c9028a&type=Documents

When clicking the new link it provides an "Invalid File reference" error. Visiting the document full details object and downloading is fine (and works) so the file is correctly stored.

Expected Behavior

CLicking the download/preview links on the subpanel should download the file.

Actual Behavior

Get a white page with "Invalid file reference"

Possible Fix

Link is wrong, its pulling "type=" from the parent object rather than the Document Object.

Steps to Reproduce

1. Clean install of Suite 7.10.10
2. Install demo data
3. upload a document to any Account via the quick form
4. within the account try and click the link from the subpanel

Context

Your Environment

• SuiteCRM Version used: 7.10.10
• Browser name and version (e.g. Chrome Version 51.0.2704.63 (64-bit)): Chrome/FF
• Environment name and version (e.g. MySQL, PHP 7): MySQL PHP7 FPM
• Operating System and version (e.g Ubuntu 16.04): Debian

[pgorod]

I've seen a similar thing recently with Images, also the type=module part comes out wrong. I suppose both issues come from the same code change, it would be nice to start by determining the commit the changed this...

[J-Light]

I think its was introduced in commit 0b7567c and relates #5822. @PedroErnst @daniel-samson

    global $currentModule;
    $displayParams['module'] = $currentModule;

The Value of $displayParams is as follows:

 |-[-]$displayParams[18]
 |  |-   name                             filename
 |  |-   vname                            LBL_LIST_FILENAME
 |  |-   width                            20%
 |  |-   module                           Documents
 |  |-   sortable                         false
 |  |-[-]displayParams[1]
 |  |  `-   module                           Documents                                               

The module field is then overwritten to the the current module. The smarty template is

type={if empty($vardef.displayParams.module)}{$displayParams.module}{else}{$vardef.displayParams.module}{/if}

The condition empty($vardef.displayParams.module) is True so $displayParams.module is used which results in type not equal Documents and results in invalid link.

[jack7anderson7]

Hi @markbond1007 @J-Light Can you please test the propose fix and confirm that it works as expected.
#6599

[markbond1007]

@jack7anderson7 I have tried this fix and can confirm the links work correctly after applying the patch (7.10.10 Suitecrm)

[J-Light]

@jack7anderson7 👍 ... tested and works, thanks.

[samus-aran]

Thanks @markbond1007 & @markbond1007 You're testing is very much appreciated! Thats it merged into the next release.