Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should have a way to add composer dependencies safe-upgrade #6950

Closed
Abuelodelanada opened this issue Feb 14, 2019 · 0 comments
Closed

We should have a way to add composer dependencies safe-upgrade #6950

Abuelodelanada opened this issue Feb 14, 2019 · 0 comments
Labels
Status:Fix Proposed A issue that has a PR related to it that provides a possible resolution Type:Suggestion Issue containing a suggestion of functionality, process or UI. Associated PRs are called enhancement
Milestone
7.11.4

Comments

@Abuelodelanada
Copy link
Contributor

Issue

When developing it is very useful to add new dependencies to composer.json.
But adding your custom dependency to composer.json file is not safe-upgrade.

Expected Behavior

Would be great to have a way to add custom dependencies in a safe-upgrade mode

Actual Behavior

Modifying composer.json file is not safe-upgrade

Possible Fix

May be we could use composer-merge-plugin

Context

Fixing this would make developers life happier.

Your Environment

  • SuiteCRM Version used: 7.10.x - 7.11.x
@Dillon-Brown Dillon-Brown added the Type:Suggestion Issue containing a suggestion of functionality, process or UI. Associated PRs are called enhancement label Feb 15, 2019
Abuelodelanada added a commit to gcoop-libre/SuiteCRM that referenced this issue Feb 19, 2019
@Abuelodelanada
FIX salesagility#6950 - Add wikimedia/composer-merge-plugin
9d60f6c
Abuelodelanada added a commit to gcoop-libre/SuiteCRM that referenced this issue Feb 19, 2019
@Abuelodelanada
FIX salesagility#6950 - Add wikimedia/composer-merge-plugin
de5f873
@Abuelodelanada Abuelodelanada mentioned this issue Feb 19, 2019
Closed
6 tasks
@Abuelodelanada Abuelodelanada mentioned this issue Feb 19, 2019
Merged
6 tasks
@Dillon-Brown Dillon-Brown added the Status:Fix Proposed A issue that has a PR related to it that provides a possible resolution label Mar 3, 2019
@Dillon-Brown Dillon-Brown added this to the 7.11.4 milestone Apr 19, 2019
Dillon-Brown added a commit that referenced this issue Apr 19, 2019
@Dillon-Brown
Merge pull request #6976 from gcoop-libre/hotfix-7.10.x_6950
6d85400 
FIX #6950 - Add wikimedia/composer-merge-plugin
@gymad gymad closed this as completed in e5526a5 Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status:Fix Proposed A issue that has a PR related to it that provides a possible resolution Type:Suggestion Issue containing a suggestion of functionality, process or UI. Associated PRs are called enhancement
Projects
None yet
Milestone
7.11.4
Development

No branches or pull requests
3 participants
@Abuelodelanada @Dillon-Brown @Mac-Rae