Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #9548 - Wrong decimal precision returned in a Modify Record workflow action #10055

Merged
merged 1 commit into from Jun 22, 2023
Merged

Fix #9548 - Wrong decimal precision returned in a Modify Record workflow action #10055

merged 1 commit into from Jun 22, 2023

Conversation

serhiisamko091184
Copy link
Contributor

Description

#9548
Issue is fully described in ticket + after analysis code base doesn’t use always default_currency_signifacant_digits, it uses user preferences.

Motivation and Context

Make one of workflow's actions working properly with decimals.

How To Test This

See #9548

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@jack7anderson7 jack7anderson7 added Status: Requires Code Review Needs the core team to code review Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member labels May 15, 2023
@jack7anderson7 jack7anderson7 added Status: Passed Code Review Mark issue has passed code review reviewed and removed Status: Requires Code Review Needs the core team to code review labels May 31, 2023
johnM2401
johnM2401 approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@johnM2401 johnM2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jack7anderson7 jack7anderson7 merged commit c128dc7 into salesagility:hotfix-7.13.x Jun 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnM2401 johnM2401 johnM2401 approved these changes

@jack7anderson7 jack7anderson7 jack7anderson7 approved these changes

Assignees
No one assigned
Labels
Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Passed Code Review Mark issue has passed code review reviewed Status: Passed Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@serhiisamko091184 @johnM2401 @jack7anderson7