Fix #5390 - Redundant message when duplicating a survey #10058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack7anderson7
added
Status:Assessed
jack7anderson7
added
the
Area:Surveys
modules/Surveys/Lines/Lines.php
Outdated
| @@ -27,7 +27,7 @@ function ($a, $b) { | |||
| ); | |||
| $smarty->assign('questions', $questions); | |||
| $smarty->assign('message', ''); | |||
| if ($view == 'EditView') { | |||
| if ($view == 'EditView' && $_REQUEST['isDuplicate'] === false) { | |||
There was a problem hiding this comment.
Hi @serhiisamko091184, we need to check if $_REQUEST['isDuplicate'] is set, otherwise we can get warnings/notices. Something like:
$isDuplicate = $_REQUEST['isDuplicate'] ?? false;
if ($view == 'EditView' && $isDuplicate === false) {There was a problem hiding this comment.
Thanks for feedback @clemente-raposo ,
I did requested changes.
Thanks a lot!
Regards,
Serhii
clemente-raposo
added
the
Status:Requires Updates
serhiisamko091184
force-pushed
the
bugfix-012
branch
from
525b7fa
to
ad29109
Compare
serhiisamko091184
removed
the
Status:Requires Updates
clemente-raposo
approved these changes
Sep 11, 2023
clemente-raposo
added
Status: Requires Testing
johnM2401
added
Status: Passed Testing
and removed
Status: Requires Testing
johnM2401
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #5390
Description
#5390
Motivation and Context
We check through global request weather data comes from duplication button or not. It helps to show message where it's necessary and avoid where it is not.
How To Test This
All the detail are given in the issue description.
Types of changes
Final checklist