Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9016 - Due_date has wrong format in subpanel #10134

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

Maratagliullin
Copy link

@Maratagliullin Maratagliullin commented Aug 3, 2023

Description

Due dates are not formatted correctly in the subpanels history and activity in the Opportunities module, I suppose this is a general problem is not related only to Opportunities but related aliases in fields.

Motivation and Context

Fixes #9016

How To Test This

go https://demo.suiteondemand.com/ latest version suitecrm 7.13.4
Open opportunities and create 3 Task with date due in activity subpanel.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@SuiteBot
Copy link

SuiteBot commented Aug 3, 2023

CLA assistant check
All committers have signed the CLA.

@serhiisamko091184 serhiisamko091184 added Status: Requires Code Review Needs the core team to code review Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member PR 4-8 Score given to PRs once assessed labels Aug 8, 2023
@serhiisamko091184
Copy link
Contributor

Hello @Maratagliullin ,

thank you very much for your contribution!

Regards,
Serhii

Copy link

@JamesBrickell JamesBrickell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, wouldn't the empty($fields[strtoupper($list_field['alias'])]) need to be changed as well to !empty($fields[strtoupper($list_field['alias'])])?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR 4-8 Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Requires Code Review Needs the core team to code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Field Due_date has wrong format in subpanel (activity, history)
4 participants