Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8209 - Issue with dynamic drop being mass updated. #10340

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

SinergiaCRM
Copy link
Contributor

@SinergiaCRM SinergiaCRM commented Jan 26, 2024

Description

In listview, mass update did not filter the child list based on the parent list. This allowed selecting items from the child list without first selecting an item from the parent list, which could lead to incorrect associations.

Motivation and Context

Dynamic dropdown was no working in massupdate.
In Cases module, the "State" field had parentenum, a property of dynamicenums. Moreover, a change has been made to make dynamic dropdown work properly in this module.

How To Test This

  1. Go to Administration and generate a dropdown, and an associated dynamic dropdown.
  2. Execute Mass Update action and modify the fields of the created dropdown and dynamic dropdown.
  3. Verify that the child list is filtered based on the value of the parent list.
  4. Check that in the edit view, the dynamic dropdowns are filtered properly.
  5. Go to Cases and verify that "State" filters "Status".

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@SinergiaCRM SinergiaCRM changed the title Fix #8209-Issue with dynamic drop being mass updated. Fix #8209 - Issue with dynamic drop being mass updated. Jan 30, 2024
@serhiisamko091184 serhiisamko091184 added Status: Requires Code Review Needs the core team to code review Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Area: Cases Issues & PRs related to all things regarding cases Branch:Hotfix PR 4-8 Score given to PRs once assessed labels Jan 30, 2024
@serhiisamko091184
Copy link
Contributor

Hello @SinergiaCRM,

thanks for your PR!

Regards,
Serhii

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Cases Issues & PRs related to all things regarding cases Branch:Hotfix PR 4-8 Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Requires Code Review Needs the core team to code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with dynamic drop being mass updated
2 participants