Fix security groups language files (PHP 5.5 compatibility) #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanSiero
changed the title
mattlorimer
added
the
Status:Fix Proposed
|
fixes #78 |
Dillon-Brown
removed
the
Status:Fix Proposed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using SuiteCRM in the spanish language, the JavaScript language files are not compiled correctly, causing the jscalendar to show english titles. (english month names instead of the spanish ones)
This is caused by stray characters in Latin1 encoding in UTF8 language files. the JSON encoder stumbled on these characters, because it only accepts UTF8 as of PHP version 5.5.
These Latin1 characters are present in the Security Groups language files of es, fr, it and pt.
The diffs in Github don't show the changes, because apparently github adapts to the character encoding of each line. However, when you inspect the previous version of the file (showed as latin1 in Github) and the new file (showed as UTF8), the difference is shown.