Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to choose page size and orientation in pdf templates #2275

Merged
merged 6 commits into from
Apr 5, 2017

Conversation

sgaved
Copy link
Contributor

@sgaved sgaved commented Sep 21, 2016

Description

Modify the current pdf templates so that you can choose the page size and orientation of the pdf. Addresses suggestion #628

Motivation and Context

Allows users to create pdfs in formats other than A4 Portrait.

How To Test This

Create a new template and modify the orientation and page size, then create a pdf.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@horus68
Copy link
Contributor

horus68 commented Oct 6, 2016

Why not creating an A3 size?
I'm waiting for this PR to be merged!

@immhub
Copy link

immhub commented Mar 7, 2017

Hello, i changed my files but when i hit save it does not do anything. (white page)
Please Help

@sgaved
Copy link
Contributor Author

sgaved commented Mar 7, 2017

@immhub you would need to do a repair and rebuild and execute the query if you added this manually

@immhub
Copy link

immhub commented Mar 8, 2017

Sorry for the noob question but what query do i have to execute ?

tkx in advanced 👍

@immhub
Copy link

immhub commented Mar 9, 2017

Found it .... tks very much 🥇 👍

@Dillon-Brown Dillon-Brown added the Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member label Apr 5, 2017
@samus-aran
Copy link
Contributor

@samus-aran samus-aran changed the base branch from develop to hotfix April 5, 2017 17:07
@samus-aran samus-aran added the Status:In Review Pull Requests that are activity being reviewed by the core team label Apr 5, 2017
@samus-aran samus-aran merged commit e316a02 into salesagility:hotfix Apr 5, 2017
@Dillon-Brown Dillon-Brown removed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status:In Review Pull Requests that are activity being reviewed by the core team labels Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants