Add IP address to FAILED LOGIN for Fail2Ban #3285 #50 #653 #3291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add IP address to FAILED LOGIN log entry so that Fail2Ban will be able to detect hackers and ban their IP from logging in for some time. In response to requests in issue salesagility#3285 and several other issues over the years.
chris001
changed the title
Dillon-Brown
added
the
Status:Assessed
|
Let's not forget this PR by @JimMackin that is merged into a feature branch, but not master... #2897 Add user lockout and user unlock options @sergio91pt I remember you mentioned how susceptible SuiteCRM was to brute-force attacks a while ago, you might be interested in this PR too. Any special reason why this isn't merged, or is it just lack of time? Maybe it is simply forgotten, because it doesn't show as an open PR (already merged)... |
|
@daniel-samson @gymad maybe now is a good time to merge this one? And Jim Mackin's #2897 ? |
Dillon-Brown
removed
the
Status:Assessed
|
Superseded by merged PR #4190 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add IP address to FAILED LOGIN log entry so that Fail2Ban will be able to detect hackers and ban their IP from logging in for some time.
In response to requests in issue #3285, #50, and #653, and possibly others over the years.
Description
Security fix for the age of widespread hacking and data theft.
Motivation and Context
Hackers could previously try logging in with a billion passwords and eventually guess it right and break in.
How To Test This
Try to login with incorrect password.
Look at PHP log for FAILED LOGIN entry.
It should say the IP address on that log line.
Users will need to add a setting to Fail2Ban which is a string to match in the log, and cause Fail2Ban to increase a counter for the SuiteCRM app, so that X failed logins from the same IP, within Y minutes, will cause Fail2Ban to ban the hacker's IP address for Z minutes.
Types of changes
Final checklist