2 Additional Dashlet Charts #3552

ricktimmis · 2017-05-15T09:10:28Z

Description

Implements a new Chart "Module Activity" this uses the Tracker table to identify new record creation, within a configurable time frame, and across a selection of Modules. It presents this as a Horizontal Bar graph, by User, by Module.

Implements an additionally modified Sales Pipeline by Sales Stage, by Sales Agent. This chart was originally available in SugarCRM, but then removed. However, it is such a valuable Sales Management chart that I felt it needed to be reimplemented.

Additional: Superceded previous Pull Request ( Now Closed ) , for details please see :-

#114

Motivation and Context

Module Activity: Uptake of CRM by users is a change management issue. 80/20 80% Phsycology 20% Technology. This charts provides department, and / or change management with an easy way to identify who is using CRM and within which modules. Enabling management of uptaking, and providing a way to identify low activity users.

How To Test This

Load the dashlets into a dashboard view, you will need real or demo data. Configured the your periods, modules, stages and users. Then feel the magic :-)

Types of changes

Bug fix (non-breaking change which fixes an issue)
[ X] New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

My code follows the code style of this project found here.
My change requires a change to the documentation.
[X ] I have read the How to Contribute guidelines.

1.) Module Actitivy: This provides the ability to select period, user and modules. It charts newly created records across modules, and groups by user for the period specified. This chart is really useful for identifying who is actively using the SuiteCRM system, and what modules they are using. FIXME: One problem I came up against was the loading of the language and label files, I could not get the lang.php field lable definitions to be interpreted. In the interest of getting something working I have hardcoded the labels into this report, and commented out the language configurable alternatives until such time as I can figure out why it is behaving this way. I am probably just missing something small. 2.) Pipeline By Sales Agent: This is a return to a legacy chart from SugarCRM, but I believe that Sales Teams really need this chart. It presents Opportunities, by Sales Stage, by Agent It is really helpful to be able to see who is working on what opportunties, at what stage. It enables sales managers to qualify the activity of their sales team. FIXME: The langauge translation files for Russian, and Spanish are both incorrect for both Charts. Hopefully these transalations can be reviewed and corrected in due course. Module Activity report has a complicated SQL statement construction, so I have left Debug logging entries in that function. tail -f sugarcrm.log | grep 'Module Activity' Is your friend to see exactly what the query is and whom the search is being performed for. Here's hoping you find this useful, Best Wishes Rick..

Merge branch 'master' of https://github.com/salesagility/SuiteCRM

Merge branch 'master' of github.com:ricktimmis/SuiteCRM

…ted the Modules selection with appropriate modules to report on, fixed missing label in Options Configuration panel. Set the default start, and end dates to report for last 3 months. Improvements to Outcome by Month Dashlet: Introduce Sales Stages so that chart can be configured to only show certain sales stages. Fixes and improvements to Pipeline by Sales Stage by Sales Agent: Fixed it so that it works, and dashlet loads ( always useful ) Improved the Query construction by JOINING data set Removed Spanish and Russian translation files as per Merge review advice.

… view to Push to ricktimmis/HotFix Merge branch 'hotfix' of https://github.com/salesagility/SuiteCRM This will then enable me to issue a New Pull request for the inclusion of these 2 Charts into SuiteCRM.

daniel-samson

Thank you for contributing your work. Please amend your pull request to meet our coding guidelines.

daniel-samson · 2017-05-15T09:40:50Z

modules/Charts/Dashlets/ModuleActivityDashlet/ModuleActivityConfigure.tpl

@@ -0,0 +1,103 @@
+{*


Please update license in the file. See https://suitecrm.com/wiki/index.php/Coding_Standards for details.

daniel-samson · 2017-05-15T09:41:24Z

modules/Charts/Dashlets/ModuleActivityDashlet/ModuleActivityDashlet.data.php

@@ -0,0 +1,65 @@
+<?php


Please update license and move entry point check after the license.

daniel-samson · 2017-05-15T09:41:43Z

modules/Charts/Dashlets/ModuleActivityDashlet/ModuleActivityDashlet.en_us.lang.php

@@ -0,0 +1,51 @@
+<?php
+if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');


again license and entrypoint

daniel-samson · 2017-05-15T09:41:59Z

modules/Charts/Dashlets/ModuleActivityDashlet/ModuleActivityDashlet.meta.php

@@ -0,0 +1,51 @@
+<?php
+if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');


license and entrypoint

daniel-samson · 2017-05-15T09:42:09Z

modules/Charts/Dashlets/ModuleActivityDashlet/ModuleActivityDashlet.php

@@ -0,0 +1,301 @@
+<?php
+if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');


again license and entrypoint

daniel-samson · 2017-05-15T09:45:40Z

modules/Charts/Dashlets/PipelineBySalesAgentDashlet/PipelineBySalesAgentDashlet.meta.php

@@ -0,0 +1,51 @@
+<?php
+if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');


update license and move entrypoint code below

daniel-samson · 2017-05-15T09:49:05Z

modules/Charts/Dashlets/PipelineBySalesAgentDashlet/PipelineBySalesAgentDashlet.meta.php

+$dashletMeta['PipelineBySalesAgentDashlet'] = array('title'       => 'LBL_TITLE',  
+                                                      'description' => 'LBL_TITLE', 
+                                                      'module'        => 'Opportunities', 
+	                                                  'icon'		  => 'icon_Charts_Horizontal_32.gif',


Please use a SVG when possible.

Here I am re-using the standard Horizontal Bar graph icon, which exists in /themes//images
I am afraid I don't have an SVG for that, there is a .svg available in SuiteP, but it's not there in the Suite7 or SuiteR directories.
I am hoping that perhaps the Theme developers have worked around that, by falling back to .gif or .png so am changing the code to look for the .svg with the thinking that it will be there anyway should you release this enhancement.

Done

daniel-samson · 2017-05-15T09:49:32Z

modules/Charts/Dashlets/PipelineBySalesAgentDashlet/PipelineBySalesAgentDashlet.php

@@ -0,0 +1,229 @@
+<?php
+if(!defined('sugarEntry') || !sugarEntry) die('Not A Valid Entry Point');


update license and move entrypoint code below the license

daniel-samson · 2017-05-15T09:50:19Z

modules/Charts/Dashlets/PipelineBySalesAgentDashlet/PipelineBySalesAgentDashlet.php

+    {
+        global $timedate;
+
+        if(empty($options['pbss_date_start']))


Please use curly braces ( { ... } ) for if statements.

daniel-samson · 2017-05-15T09:51:28Z

modules/Charts/Dashlets/PipelineBySalesAgentDashlet/PipelineBySalesAgentDashlet.php

+        }
+
+        $result = $db->query($query);
+        while($row = $db->fetchByAssoc($result, false))


Please use curly braces for looping statements ( { .. } ).

…dards, as per review in Pull Request salesagility#3552

daniel-samson

Well Done!

The code looks much better. We just need to test these changes. @Dillon-Brown Can you please test these changes?

If anyone in the community could also test them in their environments that would also be helpful.

Dillon-Brown · 2017-05-15T15:58:09Z

Hi @ricktimmis I've encountered some issues with the module activity chart. It seems that certain modules are causing the dashlet to return no data when they are selected with modules that return data when selected on their own. For example: Schedulers, Saved search, and Calendar will cause the dashlet to show no data when selected with contacts.

Would it possible to restrict these modules from appearing as an option for the user to select?

daniel-samson · 2017-05-29T11:03:38Z

@ricktimmis Any update on the possibility of restricting the modules?

horus68 · 2018-02-12T16:12:59Z

@daniel-samson @ricktimmis Should I consider this a feature that will not be implemented?

Dillon-Brown · 2018-02-14T13:01:52Z

Closed due to inactivity.

Rick.Timmis and others added 6 commits January 23, 2015 15:06

Synchronise with upstream

f8268b3

Merge branch 'master' of https://github.com/salesagility/SuiteCRM

Pulling from upstream to catch up with Master

4171ac9

Merge branch 'master' of github.com:ricktimmis/SuiteCRM

Merging ricktimmis Master to Upstream ( Salesagility ) HotFix, with a…

7cdf54b

… view to Push to ricktimmis/HotFix Merge branch 'hotfix' of https://github.com/salesagility/SuiteCRM This will then enable me to issue a New Pull request for the inclusion of these 2 Charts into SuiteCRM.

ricktimmis mentioned this pull request May 15, 2017

Introduction of two additional Charts into the SuiteCRM Dashlets. #114

Closed

daniel-samson suggested changes May 15, 2017

View reviewed changes

Style, and license amends, along with changes to meet PSR coding stan…

3d6f242

…dards, as per review in Pull Request salesagility#3552

daniel-samson approved these changes May 15, 2017

View reviewed changes

Dillon-Brown added the Status:Requires Updates Issues & PRs which requires input or update from the author label May 15, 2017

Dillon-Brown closed this Feb 14, 2018

horus68 mentioned this pull request Feb 20, 2018

Sales Funnel Feature #5274

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2 Additional Dashlet Charts #3552

2 Additional Dashlet Charts #3552

ricktimmis commented May 15, 2017

daniel-samson left a comment

daniel-samson May 15, 2017

ricktimmis May 15, 2017

daniel-samson May 15, 2017

ricktimmis May 15, 2017

daniel-samson May 15, 2017

ricktimmis May 15, 2017

daniel-samson May 15, 2017

ricktimmis May 15, 2017

daniel-samson May 15, 2017

ricktimmis May 15, 2017

daniel-samson May 15, 2017

ricktimmis May 15, 2017

daniel-samson May 15, 2017

ricktimmis May 15, 2017

daniel-samson May 15, 2017

ricktimmis May 15, 2017

daniel-samson May 15, 2017

ricktimmis May 15, 2017

daniel-samson May 15, 2017

ricktimmis May 15, 2017

daniel-samson left a comment •

edited

Dillon-Brown commented May 15, 2017 •

edited

daniel-samson commented May 29, 2017

horus68 commented Feb 12, 2018

Dillon-Brown commented Feb 14, 2018

		@@ -0,0 +1,51 @@
		<?php
		if(!defined('sugarEntry') \|\| !sugarEntry) die('Not A Valid Entry Point');

		@@ -0,0 +1,301 @@
		<?php
		if(!defined('sugarEntry') \|\| !sugarEntry) die('Not A Valid Entry Point');

		@@ -0,0 +1,229 @@
		<?php
		if(!defined('sugarEntry') \|\| !sugarEntry) die('Not A Valid Entry Point');

2 Additional Dashlet Charts #3552

2 Additional Dashlet Charts #3552

Conversation

ricktimmis commented May 15, 2017

Description

Motivation and Context

How To Test This

Types of changes

Final checklist

daniel-samson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daniel-samson left a comment • edited

Choose a reason for hiding this comment

Dillon-Brown commented May 15, 2017 • edited

daniel-samson commented May 29, 2017

horus68 commented Feb 12, 2018

Dillon-Brown commented Feb 14, 2018

daniel-samson left a comment •

edited

Dillon-Brown commented May 15, 2017 •

edited