Fixed #3859. Added help field in title tag for every textarea and input generated

[javitoron]

Description

Added title='{{$vardef.help}}', title='{$fields.{{$city}}.help}', title='{$fields.{{$state}}.help}'...
You set help for address fields in Studio but then is not displayed when you go into the EditView.

Motivation and Context

Displaying help text in address auto generated fields

How To Test This

You set help for account billing address and billing city. then you go to new account and mouse over billing address and billing city.

Types of changes
[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to change)

Final checklist
[X] My code follows the code style of this project found here.
[X] My change requires a change to the documentation.
[X] I have read the How to Contribute guidelines.

[daniel-samson]

Review: Thank you for your contribution. Please review my requested changes?

[daniel-samson]

Please only include the fix in your pull request. Please remove.

[javitoron]

sorry, newbie here... I only included the changed file... do you want me to include only the changed lines? not sure about how to do that...

and what do I have to remove?

[daniel-samson]

Please only include the fix in your pull request. Please remove.

[gymad]

Please do not change the time-stamp.

[javitoron]

??? :-(

[pgorod]

@javitoron I know what you did wrong because it has happened to me before...

When you start your PR, you have to pay attention to where you are starting it from, because if it is the incorrect branch, or if that branch in your repo is not up to date with the branch on salesagility/SuiteCRM, then you get problems like this. You see, a PR always includes every difference between two branches, not just the changes you did deliberately to fix something.

So the normal workflow for you would be to first bring your hotfix branch up-to-date with salesagility/SuiteCRM:hotfix, then start a new branch in your repo (you must start it from within hotfix), make the changes, make the PR.

Now, that's the explanation; but to give you some practical steps to get you out of this mess, let me first ask: are you using only the online GitHub website for this, or do you have a local copy of the repo in Linux, that you can handle with git?

[javitoron]

Yep, I have my own git in my server and I only use github to share the fixes I'm making there...

[pgorod]

Good. Check out this blog post of mine, it shows how to bring the hotfix branch up to date.

You can either run the whole script as a fire-and-forget thing in a new directory, or just look inside the script for the commands to use in your current git repo (without needing to fetch everything down again).

But after you update hotfix you still have to move your commits from your master into a new branch (tip: never use master in these workflows). Here you have two options again:

• either use all available git-fu in the universe doing this,

• or do it the lazy way. Since your commit touches only one file, just go into that changed file and copy all its contents. Now checkout your own hotfix, start a new branch from there called patch-help-fields or something, edit the file pasting all the new contents, commit it, push it up to origin. Now edit this PR to get it's stuff from javitoron/SuiteCRM:patch-help-fields by changing it's head branch here on SalesAgility's GitHub.

Don't worry, git starts feeling easy after a while (like 14 months or something) :-)

[javitoron]

soooo.... ok... could I just delete the repository and start a new one forked from salesagility:hotfix??

[daniel-samson]

@jamesryanalexander You shouldn't have to delete your fork. Here is what to do.

So when you clone your fork down to a new local repository then add a new remote called upstream and point it the salesagility repository. Example

$ git clone https://github.com/javitoron/SuiteCRM.git SuiteCRM
$ git remote add upstream https://github.com/salesagility/SuiteCRM.git
$ git fetch --all

if you already have cloned down your fork, then you can simply skip the first command.

Then checkout the upstream (sales agility) hotfix

$ git checkout upstream/hotfix
$ git checkout -b hotfix

This will give you to the latest hotfix branch. You need to create a new branch from hotfix.

git checkout -b fix_3859

Then all you need to do is make the changes again or you can cherry pick the changes you have made.

In future, when you need to create a new fix, simply update your hotfix branch then create a new branch from hotfix:

$ git checkout hotfix
$ git fetch --all
$ git reset --hard upstream/hotfix
$ git checkout -b new_branch_name

when you are making new features you simply do that same command but change them from hotfix to develop.

[javitoron]

well... It doesn't matter, It's embarrasing but I haven't been able to follow your instructions, mainly because I don't know how to connect to github using a console.

I have my git server and I barely put to work my git repository with production and develompent instances.

And I just wanted to pay back with this project with the fixes I make... that's why I used github... and I only use it for that.

Sure I'm missing something and I really appreciate your help, but I can't lose more time trying to set up the repository... so I ended deleting the repository, where I only had my pull requests and forked from hotfix to pull some new fixes I have...

Thanks!

[javitoron]

Hi @samus-aran! is there anything else I can/must do?

[javitoron]

Is this going to be merged or should I make the request again from the correct branch? or try it at least...

[Dillon-Brown]

Hi @javitoron, there are few code review comments that still need fixed. In this PR you have included README.md and suitecrm_version.php which will need to be removed before this can get merged. Please see the comments by pgorod for why this occurred. Thanks for the contribution!