Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4032 broken Module Builder Layouts screens #4047

Closed
wants to merge 2 commits into from

Conversation

pgorod
Copy link
Contributor

@pgorod pgorod commented Jul 26, 2017

Description

See the Issue #4032 for an explanation.

How To Test This

Enter module builder, create new module, access any layout screen. With the bug, the layout doens't even open. With the fix, it all works fine again.

But attention, I am doing this change superficially, without a real understanding of these classes and with limited PHP expertise, please consider what other implications this change might have, in other places which I might have failed to check! Thanks

Types of changes

  • [ X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • [ X ] My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • [ X ] I have read the How to Contribute guidelines.

@daniel-samson
Copy link
Contributor

I have a more correct fix for this in my pull request #3918. This corrects this issue plus other issues in module builder.

@pgorod pgorod closed this Jul 26, 2017
@pgorod pgorod deleted the patch-6 branch July 26, 2017 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants