Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log level "Warn" cleanup #4320

Merged

Conversation

Dillon-Brown
Copy link
Contributor

@Dillon-Brown Dillon-Brown commented Sep 27, 2017

Description

This fixes the suitecrm.log from getting filled with spam when set to log level "Warn". This should solve all warning mentioned by @pgorod in #3401. In total:

  • Image List.gif not found
  • Image Create.gif not found
  • Image View_Email_Templates.gif not found
  • Image Schedule_Meeting.gif not found
  • Image Schedule_Call.gif not found
  • Image Resource_Chart.gif not found
  • Image View_Project_Tasks.gif not found
  • Image Create_Person_Form.gif not found
  • Image View_Create_Email_Templates.gif not found
  • Image View_Diagnostics.gif not found
  • Image Create_Security_Group.gif not found
  • Image Create_Contact_Vcard.gif not found
  • Image View.gif not found
  • Image View_Process_Audit.gif not found
  • Image Today.gif not found
  • Image CREATEOutboundEmailAccounts.gif not found
  • Image EmailMarketing.gif not found
  • Image Role_Management.gif not found
  • Image Quick_Radius_Map.gif not found
  • Image Create_Lead_Vcard.gif not found
  • Image List_Maps.gif not found
  • Image icon_Administration_32.png not found
  • Image icon_EmailMan_32.png not found
  • Image icon_Home_32.png not found
  • Image icon_UpgradeWizard_32.png not found
  • Image icon_InboundEmail_32.png not found
  • Image _image_inline.gif not found
  • Image png_image_inline.gif not found
  • Image icon__32.png not found
  • Image sub_panel\EmailMarketing.svg not found
  • Image icon_loading.gif not found
  • Image sidebar/modules\InboundEmail.svg not found
  • Image select.gif not found
  • Image clear.gif not found

Motivation and Context

Issue reference: #3401
Issue reference: #3038

This PR also replaces #4169, #3401, #3398

How To Test This

  1. Set log level to "Warn".
  2. Check that the log is not spammed with "Image not Found".
  3. Check that the sidebar and sub-panel icons are visible.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@pgorod
Copy link
Contributor

pgorod commented Feb 3, 2018

My logs keep asking for this PR to be merged

Fri Feb  2 15:11:02 2018 [31564][1][WARN] Image List.gif not found
Fri Feb  2 15:11:02 2018 [31564][1][WARN] Image Create.gif not found
Fri Feb  2 15:11:02 2018 [31564][1][WARN] Image List.gif not found
Fri Feb  2 15:11:02 2018 [31564][1][WARN] Image Create_Security_Group.gif not found
Fri Feb  2 15:11:02 2018 [31564][1][WARN] Image Create.gif not found

:-)

@daniel-samson
Copy link
Contributor

daniel-samson commented Jul 6, 2018

Assessed

Approved with PullApprove

@daniel-samson daniel-samson merged commit a6a1b0f into salesagility:hotfix-7.8.x Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants