Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated advanced search to show results first #4323

Open
wants to merge 1 commit into
base: hotfix-7.10.x
Choose a base branch
from

Conversation

Dillon-Brown
Copy link
Contributor

Description

Modified the advanced search results to return found results before returning modules with no results. This saves the user from having to scroll past "No Results" until they find what they are looking for.

Before:
screenshot 112

After:
screenshot 111

The results will follow the order the user has set in the "Enabled Modules" box but will now also display the modules that it found results in first.

How To Test This

  1. Search for a record in the CRM
  2. Check that the returned results displays "No Results" last.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@Dillon-Brown Dillon-Brown changed the base branch from hotfix-7.8.x to hotfix December 28, 2018 10:59
@salesagility salesagility deleted a comment Dec 28, 2018
gymad
gymad previously approved these changes Dec 28, 2018
@Dillon-Brown Dillon-Brown changed the base branch from hotfix to hotfix-7.10.x August 5, 2019 13:28
@mattlorimer mattlorimer added the PR:Type:Enhancement Pull requests that provide more functionality. Associated Issues are called suggestions label May 14, 2020
@SuiteBot
Copy link

SuiteBot commented Aug 27, 2020

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:Type:Enhancement Pull requests that provide more functionality. Associated Issues are called suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants