Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid including cache and upload folder into JS minify path #4892

Merged

Conversation

PedroErnst
Copy link
Contributor

@PedroErnst PedroErnst commented Jan 10, 2018

Updated the list of excluded folders for the JS minify utils.
Added 'upload'
Modified 'cache/' to 'cache'

Motivation and Context

Minify JS would fail sometimes if it encountered unexpected contents in the upload folder.
Also the cache folder was not being excluded because of a trailing slash character.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@Dillon-Brown Dillon-Brown changed the base branch from master to hotfix January 10, 2018 11:18
@Dillon-Brown Dillon-Brown merged commit 83556e2 into salesagility:hotfix Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants