Fix/home page php notices #5162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoltankocsardi
suggested changes
Feb 9, 2018
include/Dashlets/Dashlet.php
Outdated
| @@ -242,7 +242,9 @@ public function getHeader($text = '') | |||
| $template->assign('CONFIGURE_ICON', $this->setConfigureIcon()); | |||
| $template->assign('REFRESH_ICON', $this->setRefreshIcon()); | |||
| $template->assign('DELETE_ICON',$this->setDeleteIcon()); | |||
| $template->assign('DASHLET_MODULE',$this->seedBean->module_name); | |||
| if(!empty($this->seedBean) && !empty($this->seedBean->module_name)) { | |||
There was a problem hiding this comment.
First part of this condition is unnecessary.
|
Assessed |
Dillon-Brown
added
the
Status:Assessed
samus-aran
added
the
Status: Requires Code Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated some of the php files to address the PHP warning notices.
How To Test This
This has been done with focus on the home page. Lowering the suppression of the messages and loading the home page should now show a reduced number of php warning notices.
Types of changes
Final checklist