Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5602 icons not shown in add dashlet search. #5606

Merged

Conversation

e-reeley
Copy link
Contributor

@e-reeley e-reeley commented Mar 27, 2018

Description

This change allows the icons to be shown within the search feature of 'Add dashlet' instead of just the file name.

Motivation and Context

Issue #5602

How To Test This

  1. From the homepage click on the actions tab
  2. Select add dashlet
  3. Enter in a search string, e.g. 'My'
  4. See that the modules and icons are correctly displayed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@Dillon-Brown
Copy link
Contributor

Dillon-Brown commented Mar 27, 2018

Assessed

Approved with PullApprove

@Dillon-Brown Dillon-Brown added the Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member label Mar 27, 2018
@Dillon-Brown Dillon-Brown merged commit 3a3c89a into salesagility:hotfix Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants