Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSR2 - class definition #6083

Merged
merged 1 commit into from Jul 10, 2018
Merged

Conversation

Dillon-Brown
Copy link
Contributor

Description

Part of a series of small incremental non-breaking changes to make SuiteCRM fully PSR-2 compliant.

Motivation and Context

https://www.php-fig.org/psr/psr-2/

How To Test This

See Travis

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@codecov-io
Copy link

Codecov Report

Merging #6083 into hotfix will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           hotfix    #6083   +/-   ##
=======================================
  Coverage    7.23%    7.23%           
=======================================
  Files        3400     3400           
  Lines      332825   332825           
=======================================
  Hits        24078    24078           
  Misses     308747   308747
Impacted Files Coverage Δ
include/SugarFields/Parsers/EditViewMetaParser.php 0% <ø> (ø) ⬆️
...odules/AOS_PDF_Templates/PDF_Lib/classes/meter.php 0% <ø> (ø) ⬆️
.../SugarFields/Parsers/Rules/VariableCleanupRule.php 0% <ø> (ø) ⬆️
include/SugarObjects/forms/FormBase.php 0% <ø> (ø) ⬆️
...shlets/AOW_WorkFlowDashlet/AOW_WorkFlowDashlet.php 0% <ø> (ø) ⬆️
...nclude/SugarFields/Parsers/Rules/BugsParseRule.php 0% <ø> (ø) ⬆️
include/SugarFields/Fields/File/SugarFieldFile.php 0% <ø> (ø) ⬆️
...mailAccounts/SyncInboundEmailAccountsException.php 0% <ø> (ø) ⬆️
include/MySugar/MySugar.php 6.01% <ø> (ø) ⬆️
modules/AOS_Contracts/controller.php 0% <ø> (ø) ⬆️
... and 555 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b325fa4...835a460. Read the comment docs.

@daniel-samson
Copy link
Contributor

daniel-samson commented Jul 10, 2018

Assessed

Approved with PullApprove

@daniel-samson daniel-samson merged commit 66df835 into salesagility:hotfix Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants