Fixed cron php notice #6375
Open
Fixed cron php notice #6375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gymad
previously approved these changes
Oct 1, 2018
mattlorimer
reviewed
Oct 4, 2018
|
Please rebase this pull request to the hotfix-7.10.x branch as version 7.8.x of SuiteCRM has reached its end of life and therefore will no longer be receiving updates. For more information about 7.8.x end of life please visit our blog post |
Mac-Rae
added
the
PR:Wrong Branch
|
@Dillon-Brown I'm not sure if we use cronjobs more than other users, but our logs are being absolutely battered by this (at least, I think it's this issue, the line number is almost the same). We have a comment at the top of the file that's 5 lines long, but other than that the file is exactly the same as it is on 7.10.19. The rest of the line difference between your error and mine can presumably be explained by the changes made to the file since this issue was opened. |
|
I also have this: I'm on 7.10.19, PHP 7.0, MySQL 5.7, Debian Linux. I'd appreciate if this PR were rebased so it can be merged :) I'll try to backport it and report back whether it fixes the problem. |
|
@Dillon-Brown I'm tempted to just backport this change and deploy it, because I can't for the life of me figure out how to reproduce it locally but it's spamming up our logs. How confident would you say you are in this fix? :) (also could you have it run in CI so I at least have that to comfort me 😄) |
Mac-Rae
removed
the
PR:Wrong Branch
|
|
mattlorimer
force-pushed
the
hotfix-7.10.x
branch
2 times, most recently
from
3149dea
to
ab954a4
Compare
mattlorimer
force-pushed
the
hotfix-7.10.x
branch
from
1609e8b
to
b06335d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes php notices.
Motivation and Context
How To Test This
php -f cron.phpTypes of changes
Final checklist