Changes for inline edit date/datetime #5526 #6669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitbnw
changed the title
Codecov Report
@@ Coverage Diff @@
## hotfix #6669 +/- ##
==========================================
+ Coverage 7.28% 7.28% +<.01%
==========================================
Files 3729 3729
Lines 385999 385998 -1
==========================================
Hits 28122 28122
+ Misses 357877 357876 -1 |
Dillon-Brown
added
the
PR:Community Contribution
|
Please rebase this pull request onto hotfix-7.10.x as the hotfix branch is now specifically for 7.11.x issues. Please take a look at our contribution guidelines for more information. |
Mac-Rae
added
the
PR:Wrong Branch
mattlorimer
removed
the
PR:Wrong Branch
Codecov Report
@@ Coverage Diff @@
## hotfix #6669 +/- ##
=========================================
Coverage 11.45% 11.45%
Complexity 41635 41635
=========================================
Files 3292 3292
Lines 245846 245841 -5
=========================================
Hits 28169 28169
+ Misses 217677 217672 -5 |
mattlorimer
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes my attempt to fix issue #5526
Description
The inline editing of date fields was still not displaying a value after an edit.
I believe the cause was php datetime format function would incur a fatal error when attempting to format a date value with a datetime string. So I split the formatting depending on the field type.
Motivation and Context
How To Test This
Use inline editing for any date or datetime field and see if the correct value displays after saving.
Types of changes
Final checklist