Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #6998 - cron.php fails because there is no check whether ElasticSearch is enabled #7020

Merged
merged 1 commit into from Mar 25, 2019

Conversation

Dillon-Brown
Copy link
Contributor

Description

Fixes an issue where the callback for save beans in the ElasticSearchHooks would trigger regardless of whether elasticsearch was enabled.

Motivation and Context

Issue reference: #6998

How To Test This

  1. Disable elasticsearch.
  2. Refresh the homepage and check the log, you should no longer see elasticsearch errors.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@codecov-io
Copy link

Codecov Report

Merging #7020 into hotfix will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             hotfix    #7020      +/-   ##
============================================
+ Coverage     10.74%   10.74%   +<.01%     
- Complexity    42099    42100       +1     
============================================
  Files          3370     3370              
  Lines        247713   247714       +1     
============================================
+ Hits          26625    26626       +1     
  Misses       221088   221088

@samus-aran samus-aran merged commit 7ffc51a into salesagility:hotfix Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants