Fixed #7271 - Email Template selection in email module is not working for 7.10.16

[Dillon-Brown]

Description

Fixes an issue with the email compose buttons not returning data from the popups.

Motivation and Context

Issue reference: #7271

How To Test This

1. Open email module
2. Compose
3. Select email template

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

• My code follows the code style of this project found here.
• My change requires a change to the documentation.
• I have read the How to Contribute guidelines.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (hotfix-7.10.x@12f5974). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             hotfix-7.10.x    #7282   +/-   ##
================================================
  Coverage                 ?    7.47%           
================================================
  Files                    ?     3737           
  Lines                    ?   386898           
  Branches                 ?        0           
================================================
  Hits                     ?    28919           
  Misses                   ?   357979           
  Partials                 ?        0

[cameronblaikie]

Assessed 👍

[pgorod]

This is also merged into 7.11.5, right?

Because there seems to be some problem... https://suitecrm.com/suitecrm/forum/suitecrm-7-0-discussion/24698-email-templates-not-loading?start=15#85477

[Dillon-Brown]

@pgorod Yeah it's in 7.11.5. I'm not able to replicate, seems to work fine for me.

[kikobar]

I upgraded from 7.10.16 to 7.11.5 in one step and I still have this issue.

[pstevens71]

I'm experiencing this issue in 7.11.4. The 2 JS files referenced changes do not seem to fix the issue for me either.

[pstevens71]

Update.... I'm using cloudflare, cleared the cloudflare cache after replacing the files and after re-building the JS files (quick repair and rebuild plus the rebuild JS files options) and it now works! Thank you!!

[kikobar]

@pstevens71 could you please list the exact steps you took to make it work?

[pstevens71]

The trick is:

1. replace the two JS files with the versions here:
   https://github.com/salesagility/SuiteCRM/pull/7282/files

2. Admin/Repair/Quick repair and rebuild
   3.Admin/Repair/Repair JS Files

I also am using cloudflare so had to clear the cache AND Shift F5 to clear the browser cache (in Chrome) and it works!

If your hosting is using a cache you might want to make sure that's clear too.

[kikobar]

Thanks! I will give it a shot and will post back here.

[kikobar]

@pstevens71 @Dillon-Brown thanks a lot!
I confirm this did the trick for me too!

[kikobar]

In my case the real issue was the browser cache (silly me!!) because I tried in a new private window before trying anything else and if actually worked.
Apologies if I misled someone!