Remove repetitive instance URL visits from tests #7418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why these are failing :/ I don't think removing the move to the instance root should effect any tests. |
|
I guess this is failing because of the snapshot reloading? I guess I'll wait until after #7417 is merged to finish this PR. |
connorshea
changed the title
Dillon-Brown
added
the
PR:Community Contribution
This also removes `$I->amOnUrl($webDriverHelper->getInstanceURL())` from all files where it precedes the loginAsAdmin function, since it's now in the loginAsAdmin function.
connorshea
force-pushed
the
remove-i-am-on-url
branch
from
c78bff8
to
8e5dd0d
Compare
connorshea
changed the title
|
Passing now :) |
|
Assessed by Travis 👍 |
Mac-Rae
added
the
Status:Assessed
Dillon-Brown
approved these changes
Jun 20, 2019
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed every usage of the
loginAsAdminfunction in the acceptance test suite was preceded by a visiting the root instance URL, so I moved the instance URL visit into the login function for simplicity.This removes
$I->amOnUrl($webDriverHelper->getInstanceURL())from all files where it precedes theloginAsAdminfunction, since it's now in theloginAsAdminfunction.How To Test This
Make sure the tests pass.
Types of changes
Final checklist