Fixed #7071 - Reply to, Reply to All issue with attachment

[604media]

Fixed #7071 - Reply to, Reply to All issue with attachment

[samus-aran]

Hey @604media - Do you need help with how to format it to be PSR-2 compliant?
I'm sure you can change your settings in your IDE (what do you use btw?) to format it appropriately. Or use Robotask. https://docs.suitecrm.com/developer/automatedtasks/codingstyle/

[604media]

Hi @samus-aran and @Dillon-Brown
123ddd4
Can you please check and confirm above commits resolves PSR-2?
I'm using Eclipse and now code formatter properly set to PSR-2

[samus-aran]

@604media Looks good! @Mac-Rae Can you assess again please?

[samus-aran]

Hmm a test appears to be failing.

1. EmailTest::testSendSaveAndStoreInSentOk
   SuiteCRM\StateSaverException: Some garbage state left in stack (did you pop everything?)
   Needs to restore:
   [db_table.inbound_email] => 'inbound_email'
   [db_table.emails] => 'emails'
   [db_table.emails_text] => 'emails_text'
   [GLOBALS._POST] => '_POST'
   [GLOBALS._GET] => '_GET'
   [GLOBALS._REQUEST] => '_REQUEST'
   [GLOBALS._SESSION] => '_SESSION'
   [GLOBALS._SERVER] => '_SERVER'
   [GLOBALS._ENV] => '_ENV'
   [GLOBALS._FILES] => '_FILES'
   [GLOBALS._COOKIE] => '_COOKIE'

[604media]

Hmm a test appears to be failing.

1. EmailTest::testSendSaveAndStoreInSentOk
   SuiteCRM\StateSaverException: Some garbage state left in stack (did you pop everything?)
   Needs to restore:
   [db_table.inbound_email] => 'inbound_email'
   [db_table.emails] => 'emails'
   [db_table.emails_text] => 'emails_text'
   [GLOBALS._POST] => '_POST'
   [GLOBALS._GET] => '_GET'
   [GLOBALS._REQUEST] => '_REQUEST'
   [GLOBALS._SESSION] => '_SESSION'
   [GLOBALS._SERVER] => '_SERVER'
   [GLOBALS._ENV] => '_ENV'
   [GLOBALS._FILES] => '_FILES'
   [GLOBALS._COOKIE] => '_COOKIE'

@samus-aran Is this for me? No major changes before processing attachment I'm checking action from parent URL

[gymad]

Hi @604media
if you scroll a little bit down in the phpunit tells what the issue is exactly:

Caused by
PHPUnit_Framework_Error_Notice: Undefined index: refer_action
/home/travis/build/salesagility/SuiteCRM/modules/Emails/Email.php:3031

You should check if the request really contains a refer_action query parameter, else the php shows up an undefined index error. Also your chenges implicate that the test should make accept the results only if the request variable really exists.

[Mac-Rae]

Assessed 👍

[Mac-Rae]

Hi @604media ,

Please resolve the conflicts on this pull request bringing it up to date with the related branch?
For more information please take a look at our contribution guidelines.

If you would like assistance please ensure you select "Allow edits from maintainers" checkbox and leave us a message @tagging me!

Thanks 👍

[SuiteBot]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Dillon-Brown
❌ processflowca
_{You have signed the CLA already but the status is still pending? Let us recheck it.}