Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add composer validate job in Travis. #7451

Merged

Conversation

connorshea
Copy link
Contributor

Description

This adds a job to Travis that validates that the composer.json and composer.lock are in sync.

Motivation and Context

I forgot to update the composer.lock when adding php-cs-fixer and had to fix it in #7450. This job shouldn't take very long to run and would fix this problem.

How To Test This

Make sure Travis passes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@Mac-Rae
Copy link
Contributor

Mac-Rae commented Jun 24, 2019

Assessed by Travis 👍

@Mac-Rae Mac-Rae added the Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member label Jun 24, 2019
@Dillon-Brown Dillon-Brown merged commit f1dd383 into salesagility:hotfix-7.10.x Jun 24, 2019
@Dillon-Brown Dillon-Brown added the PR:Community Contribution These are contribution made by the community label Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:Community Contribution These are contribution made by the community Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants