Add a get_current_language() helper function #7561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be used instead of accessing the global "current_language" variable. Replace various accesses to the "authenticated_user_language" session var with a call to get_current_language(). Adds some basic unit tests.
|
Assessed by Travis 👍 |
Mac-Rae
added
the
Status:Assessed
Dillon-Brown
approved these changes
Jul 15, 2019
Dillon-Brown
added
the
PR:Community Contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This can be used instead of accessing the global "current_language" variable.
Replace various accesses to the "authenticated_user_language" session var
with a call to get_current_language().
Adds some basic unit tests.
Motivation and Context
@gymad suggested not accessing the global "current_language" in another PR, so I looked into providing a function for this instead and found lots of duplicated code that could be replaced with it.
How To Test This
Run the unit tests.
Types of changes
Final checklist