New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #7621 - Add support for config_override.test.php #7808
Fixed #7621 - Add support for config_override.test.php #7808
Conversation
1df20b6
to
ec59df9
Compare
Codecov Report
@@ Coverage Diff @@
## hotfix-7.10.x #7808 +/- ##
================================================
Coverage ? 7.28%
================================================
Files ? 3700
Lines ? 386196
Branches ? 0
================================================
Hits ? 28132
Misses ? 358064
Partials ? 0 |
We should probably have a Just this should be fine? Maybe a comment explaining what it's for. <?php
$testConfig = [
'imap_test' => true,
]; This'll be great, thank you! ❤️ |
Assessed 👍 |
Needs input from @Dillon-Brown before merging :D. |
Assessed 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
// Load up the config.test.php file. This is used to define configuration values for the test environment. | ||
$testConfig = []; | ||
|
||
if (is_file($root . 'tests/config.test.php')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it occurs to me now, wouldn't this effect all the Robo tasks that use CliRunnerTrait?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also: when I run ./vendor/bin/robo tests:unit
, at least on the StateChecker-removal branch, the config.php
file is overwritten by the contents of the config.test.php
.
Description
Motivation and Context
Issue reference: #7621
How To Test This
tests/config.test.php
file and then give it a custom value like so:config.php
andconfig_override.php
values.Types of changes
Final checklist