Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #7810 - Pencil present in Top Menu for users with non editing permission #7813

Merged
merged 2 commits into from Sep 13, 2019

Conversation

@Abuelodelanada
Copy link
Contributor

Abuelodelanada commented Sep 4, 2019

Description

Read #7810

7810_fix_1

How To Test This

  1. Create a Contact with a non admin user.
  2. Login with admin user
  3. Create a new Role and let that role to edit only owned records
  4. Assign another user (different from step 1) to the new Role
  5. Login with that user.
  6. Go to the DetailView of the Contact created in step 1.
  7. Verify there is pencil in Top Menu only for records you can edit

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.
@Abuelodelanada Abuelodelanada changed the title Fix pencil present in Top Menu for users with non editing permission FIX #7810 - Pencil present in Top Menu for users with non editing permission Sep 4, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 4, 2019

Codecov Report

Merging #7813 into hotfix-7.10.x will decrease coverage by <.01%.
The diff coverage is 0%.

@@                Coverage Diff                @@
##           hotfix-7.10.x    #7813      +/-   ##
=================================================
- Coverage           7.27%    7.27%   -0.01%     
=================================================
  Files               3699     3700       +1     
  Lines             386144   386157      +13     
=================================================
  Hits               28089    28089              
- Misses            358055   358068      +13
@Mac-Rae

This comment has been minimized.

Copy link
Contributor

Mac-Rae commented Sep 9, 2019

Assessed 👍

@Mac-Rae Mac-Rae added the Assessed label Sep 9, 2019
@Mac-Rae Mac-Rae requested review from Dillon-Brown and code-ph0y Sep 9, 2019
@Mac-Rae Mac-Rae merged commit 730dc20 into salesagility:hotfix-7.10.x Sep 13, 2019
4 checks passed
4 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
clahub All contributors have signed the Contributor License Agreement.
Details
codecov/project 7.27% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Mac-Rae Mac-Rae added this to Done in Sprint 16 Sep 13, 2019
@Abuelodelanada Abuelodelanada deleted the gcoop-libre:hotfix-7.10.x-7810 branch Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Sprint 16
  
Done
5 participants
You can’t perform that action at this time.