Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a sql query bug for quote purchase subpanel #7814

Conversation

dominicchinkh
Copy link
Contributor

@dominicchinkh dominicchinkh commented Sep 5, 2019

Fix database failure in quote purchases subpanel

Description

Fix database failure in quote purchases subpanel

Motivation and Context

The quote purchases subpanel expansion lead to a database failure

MySQL error 1055: Expression #1 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'suitecrm.aos_quotes.id' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by

How To Test This

Create a product. Create a quote that include the product as a line item. Select an account. Save the quote. Go to the product page and expand the Purchases subpanel

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@codecov-io
Copy link

Codecov Report

Merging #7814 into hotfix-7.10.x will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           hotfix-7.10.x    #7814   +/-   ##
==============================================
  Coverage           7.27%    7.27%           
==============================================
  Files               3699     3699           
  Lines             386144   386144           
==============================================
  Hits               28089    28089           
  Misses            358055   358055

@Mac-Rae
Copy link
Contributor

Mac-Rae commented Sep 18, 2019

Assessed 👍

@Mac-Rae Mac-Rae added the Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member label Sep 18, 2019
@Mac-Rae Mac-Rae merged commit 6c6f667 into salesagility:hotfix-7.10.x Sep 18, 2019
@Dillon-Brown Dillon-Brown added the PR:Community Contribution These are contribution made by the community label Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:Community Contribution These are contribution made by the community Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants