Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #7128 - Remove scheme to avoid mixed content error #8056

Merged

Conversation

grahambrown11
Copy link
Contributor

Remove scheme to avoid mixed content error

Description

Site served over HTTPS got a mixed content error, this change is to avoid the error.
This is a quick fix as according to https://datatables.net/extensions/tabletools/ TableTools are retired...

Motivation and Context

Fix #7128 for HacktoberFest

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@codecov-io
Copy link

Codecov Report

Merging #8056 into hotfix-7.10.x will increase coverage by <.01%.
The diff coverage is 0%.

@@                Coverage Diff                @@
##           hotfix-7.10.x    #8056      +/-   ##
=================================================
+ Coverage          10.49%   10.49%   +<.01%     
=================================================
  Files               3325     3325              
  Lines             243794   243794              
=================================================
+ Hits               25574    25575       +1     
+ Misses            218220   218219       -1

@Dillon-Brown Dillon-Brown added the PR:Community Contribution These are contribution made by the community label Oct 16, 2019
@cameronblaikie cameronblaikie added the Status:In Review Pull Requests that are activity being reviewed by the core team label Oct 17, 2019
@cameronblaikie
Copy link
Contributor

Assessd 👍

@cameronblaikie cameronblaikie added Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member and removed Status:In Review Pull Requests that are activity being reviewed by the core team labels Oct 17, 2019
@cameronblaikie cameronblaikie merged commit 261f07b into salesagility:hotfix-7.10.x Oct 17, 2019
@grahambrown11 grahambrown11 deleted the bugfix_7128 branch October 17, 2019 15:17
@samus-aran
Copy link
Contributor

Hey @grahambrown11 👋

Apologies on the delay but we would like to ask if you are able to provide us your shipping details so we can thank you for your hard work and time you’ve dedicated to contributing to SuiteCRM during the 2019 HacktoberFest period! 🎃 👻

HacktoberFest x SuiteCRM 2019 submission form

We will be closing the submission in 2 weeks time (Friday 7th February 2020) so we can immediately process your goodies.

If you have any concerns or feedback please reach out to us by emailing community@suitecrm.com.

Would like to thank you again for participating with us on improving the SuiteCRM codebase and we look forward to future contributions from yourself 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:Community Contribution These are contribution made by the community Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants