Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*WIP Fixed #7160 - Can't disable notifications #8167

Open
wants to merge 1 commit into
base: hotfix-7.10.x
Choose a base branch
from

Conversation

Dillon-Brown
Copy link
Contributor

Description

Fixed an issue with use save not saving the "Notify on Assignment" value.

Motivation and Context

Issue reference: #7160

How To Test This

  1. User profile -> advanced.
  2. Save "Notify on Assignment".
  3. Check that the value saved correctly.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@SuiteBot
Copy link

SuiteBot commented Aug 27, 2020

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Dillon-Brown <dillon.brown@salesagility.com>
@cameronblaikie
Copy link
Contributor

cameronblaikie commented Jun 8, 2021

Can confirm this works and code LGTM 👍

@Dillon-Brown Dillon-Brown changed the title Fixed #7160 - Can't disable notifications *WIP Fixed #7160 - Can't disable notifications Jun 30, 2021
@SinergiaCRM
Copy link
Contributor

SinergiaCRM commented Jan 25, 2022

Hi @Dillon-Brown ,

Can we get some updates about this PR?

We found that removing the property "value" of the input element solves the issue:

<slot><input name='receive_notifications' class="checkbox" tabindex='12' type="checkbox"
value="12" {$RECEIVE_NOTIFICATIONS}></slot>

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants