Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8384 - Add layout_def_key to return_url querystring in sub_p_rem #8385

Open
wants to merge 1 commit into
base: hotfix-7.10.x
Choose a base branch
from

Conversation

marin-h
Copy link

@marin-h marin-h commented Dec 16, 2019

Add layout_def_key with the value provided by get_layout_def_key() to query string in return_url variable generated in function sub_p_rem used by the SubPanelRemoveButton widget.

Description

Fixes #8384

Motivation and Context

See #8384

How To Test This

  1. In a custom module or an extension for a core module, add a non-default layout_def_key to layoutdefs or subpaneldefs with a subpanel definition on it that uses the widget SubPanelRemoveButton.
  2. Access the view that renders this new subpanel.
  3. Add a record to the subpanel.
  4. Delete the record using SubPanelRemoveButton.
  5. Record and relationship are deleted.
  6. Subpanel loads succesfully.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

…in sub_p_rem

Add layout_def_key with the value provided by get_layout_def_key() to
querystring in return_url variable generated in function sub_p_rem
used by the SubPanelRemoveButton widget.
@SuiteBot
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


marin-h seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants