Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8400 - Add definitions for js vars SUGAR.measurements and UA whe… #8401

Open
wants to merge 1 commit into
base: hotfix-7.10.x
Choose a base branch
from

Conversation

marin-h
Copy link

@marin-h marin-h commented Dec 19, 2019

Description

Fixes #8400

Motivation and Context

See #8400

How To Test This

  1. Set show_header option to false in any DetailView.
  2. Set subpaneldefs to show a subpanel.
  3. Access the view.
  4. Check that no js errors are thrown with devtools on the browser.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@marin-h marin-h requested a review from Mac-Rae January 25, 2020 13:41
@marin-h
Copy link
Author

marin-h commented Feb 27, 2020

@Dillon-Brown hi! Could you please take a look a this one? Thanks :)

@SuiteBot
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


marin-h seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@marin-h
Copy link
Author

marin-h commented Nov 26, 2020

Hey @samus-aran I see my sign is still not added to CLA on this one. Is there anything else I can do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants