Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix db convert directly calling abstract function #8594

Merged
merged 1 commit into from Mar 18, 2020

Conversation

mattlorimer
Copy link
Member

Description

#8129 introduced a direct call to an abstract database function, this PR correct it to call the function on the instantiated db object, addressing multiple issue introduced in 7.10.24/7.11.12

Motivation and Context

How To Test This

See home page charts, trimTracker Scheduled Task and everywhere else that uses this function now works as expected

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@codecov-io
Copy link

Codecov Report

Merging #8594 into hotfix-7.10.x will not change coverage.
The diff coverage is 14.39%.

@@              Coverage Diff               @@
##           hotfix-7.10.x    #8594   +/-   ##
==============================================
  Coverage          10.73%   10.73%           
==============================================
  Files               3229     3229           
  Lines             240855   240855           
==============================================
  Hits               25858    25858           
  Misses            214997   214997

@pgorod
Copy link
Contributor

pgorod commented Mar 7, 2020

Thanks Matt. This should also fix #8577, right?

@mattlorimer mattlorimer merged commit 2edb1f5 into salesagility:hotfix-7.10.x Mar 18, 2020
@connorshea
Copy link
Contributor

🙈 sorry I caused this issue, thanks for fixing it!

@mattlorimer mattlorimer deleted the fix/dbconvert branch March 31, 2020 21:08
@pgorod
Copy link
Contributor

pgorod commented Apr 20, 2020

This still needs some more fixing...

https://community.suitecrm.com/t/fehlermeldung-rechnungs-versandadresse-kopieren/72422

It's in German, but you can see all in you need form the stack trace in English.

The complete fix would be, I think

  • make a list of the functions that Connor's PR changed
  • go in DBManager and check each of them to see if they use $this inside them
  • for all those functions, make a fix similar to Matt's here: add object instantiation to the original call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants