-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused EmailImage entrypoint #8825
Open
pgorod
wants to merge
1
commit into
salesagility:hotfix
Choose a base branch
from
pgorod:patch-6
base: hotfix
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## hotfix-7.10.x #8825 +/- ##
==============================================
Coverage 10.69% 10.69%
==============================================
Files 3230 3229 -1
Lines 241063 241049 -14
==============================================
Hits 25792 25792
+ Misses 215271 215257 -14 |
mattlorimer
force-pushed
the
hotfix-7.10.x
branch
2 times, most recently
from
October 28, 2020 17:48
3149dea
to
ab954a4
Compare
mattlorimer
force-pushed
the
hotfix-7.10.x
branch
from
November 5, 2020 22:04
1609e8b
to
b06335d
Compare
serhiisamko091184
added
Status:Requires Updates
Issues & PRs which requires input or update from the author
Area: Clean Up
Issues & PRs related to all things regarding to technical debt and log files
labels
Sep 1, 2023
Done... |
- Remove EmailImage.php
jack7anderson7
force-pushed
the
patch-6
branch
from
September 1, 2023 14:47
3e7aca6
to
4cf88ee
Compare
serhiisamko091184
added
Status:Assessed
PRs that have been tested and confirmed to resolve an issue by a core team member
PR 4-8
Score given to PRs once assessed
Status: Requires Code Review
Needs the core team to code review
and removed
Status:Requires Updates
Issues & PRs which requires input or update from the author
labels
Sep 1, 2023
Thanks for quick reply and changes! Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Clean Up
Issues & PRs related to all things regarding to technical debt and log files
PR 4-8
Score given to PRs once assessed
Status:Assessed
PRs that have been tested and confirmed to resolve an issue by a core team member
Status: Requires Code Review
Needs the core team to code review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have several entry-points to get images (for Email campaigns, etc) and this one seems old and unused.
We're using others, and there seems to be an unnecessarily high number of them -
download
,getImage
,image
...How To Test This
I couldn't find any uses of this entry-point.
I found this old PR which touches the file, but it seems accidental, the other changes don't use the file. Anyway that PR is a nice place to see which files are involved in attached email images.
Types of changes
Final checklist