Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused EmailImage entrypoint #8825

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

pgorod
Copy link
Contributor

@pgorod pgorod commented Jul 20, 2020

Description

We have several entry-points to get images (for Email campaigns, etc) and this one seems old and unused.

We're using others, and there seems to be an unnecessarily high number of them - download, getImage, image...

How To Test This

I couldn't find any uses of this entry-point.

I found this old PR which touches the file, but it seems accidental, the other changes don't use the file. Anyway that PR is a nice place to see which files are involved in attached email images.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@codecov-commenter
Copy link

Codecov Report

Merging #8825 into hotfix-7.10.x will increase coverage by 0.00%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           hotfix-7.10.x    #8825   +/-   ##
==============================================
  Coverage          10.69%   10.69%           
==============================================
  Files               3230     3229    -1     
  Lines             241063   241049   -14     
==============================================
  Hits               25792    25792           
+ Misses            215271   215257   -14     

@SuiteBot
Copy link

SuiteBot commented Aug 27, 2020

CLA assistant check
All committers have signed the CLA.

@serhiisamko091184
Copy link
Contributor

Hello @pgorod ,

one more time thanks for the contribution,

Would you be so kind, make the same changes as mentioned in another PR:
#8858

Thank you very much.

Regards,
Serhii

@serhiisamko091184 serhiisamko091184 added Status:Requires Updates Issues & PRs which requires input or update from the author Area: Clean Up Issues & PRs related to all things regarding to technical debt and log files labels Sep 1, 2023
@pgorod pgorod changed the base branch from hotfix-7.10.x to hotfix September 1, 2023 11:26
@pgorod
Copy link
Contributor Author

pgorod commented Sep 1, 2023

Done...

@serhiisamko091184 serhiisamko091184 added Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member PR 4-8 Score given to PRs once assessed Status: Requires Code Review Needs the core team to code review and removed Status:Requires Updates Issues & PRs which requires input or update from the author labels Sep 1, 2023
@serhiisamko091184
Copy link
Contributor

Thanks for quick reply and changes!

Regards,
Serhii

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Clean Up Issues & PRs related to all things regarding to technical debt and log files PR 4-8 Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Requires Code Review Needs the core team to code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants