Fixed #9024 - API returns error when Note lacks attachment #9025
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The API incorrectly assumes that if the
filename
attribute exists, that the client is attempting to perform an upload. This is not always the case and in fact, many clients will return many of the attributes that are provided by aGET
request.The PR makes the application check if the
filename
is Not Empty before assuming that a file upload is in progress.Motivation and Context
This fixes #9024
It builds on #8408
How To Test This
PATCH
request with a blank (empty string)filename
attribute.The request should succeed.
Types of changes
Final checklist