Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #9024 - API returns error when Note lacks attachment #9025

Open
wants to merge 1 commit into
base: hotfix-7.10.x
Choose a base branch
from

Conversation

tsummerer
Copy link
Contributor

Description

The API incorrectly assumes that if the filename attribute exists, that the client is attempting to perform an upload. This is not always the case and in fact, many clients will return many of the attributes that are provided by a GET request.

The PR makes the application check if the filename is Not Empty before assuming that a file upload is in progress.

Motivation and Context

This fixes #9024
It builds on #8408

How To Test This

  1. Create a Note with no attachment
  2. Attempt to Edit the note by performing a PATCH request with a blank (empty string) filename attribute.
    The request should succeed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant