-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
9232 listview display url content type #9234
base: hotfix
Are you sure you want to change the base?
9232 listview display url content type #9234
Conversation
…ields of type URL (Generate link) is not displayed in listviews salesagility#9232 include dependend fields for url field in $filter_fields. public function setupFilterFields Changes to be committed: modified: ListViewDisplay.php
…ields of type URL (Generate link) is not displayed in listviews salesagility#9232 For generated 'url' field type, export valaue of default as value to display. On branch 9232_listview_display_url_content_type Cherry-pick currently in progress. Changes to be committed: modified: SugarBean.php
Your branch is up to date with 'origin/9232_listview_display_url_content_type'. Fixed also custom selectable listView (use Url's own template as originalai intended, not Link's template) Changes to be committed: modified: data/SugarBean.php renamed: include/SugarFields/Fields/URL/DetailView.tpl -> include/SugarFields/Fields/Url/DetailView.tpl renamed: include/SugarFields/Fields/URL/EditView.tpl -> include/SugarFields/Fields/Url/EditView.tpl renamed: include/SugarFields/Fields/URL/ListView.tpl -> include/SugarFields/Fields/Url/ListView.tpl modified: include/SugarFields/SugarFieldHandler.php
36c62d6
to
0115a1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm abit weary renaming tpl files in case others use it directly. Is it necessary? I know it would be inline with other fields name formats but is the effort doing it worth a potential breakage just for a lettercase. :)
@@ -80,9 +80,11 @@ public static function fixupFieldType($field) | |||
case 'date': | |||
$field = 'datetime'; | |||
break; | |||
/* #9232 user's selected column not displayed properly with link template |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @gody01 Just asking why is this commented out? Is there still more work to be done to be done?
Changes to display content of generated field of type 'url' in ListView.
Description
Fix for issue #9232 - Content of custom fields of type URL (Generate link) is not displayed in listviews
In function setupFilterFields
In function get_list_view_array
Motivation and Context
To display 'url' generated fields in listviews.
How To Test This
Types of changes
Final checklist