Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9412 - Wrong email value displayed when aborting an inline edition #9413

Merged
merged 1 commit into from Oct 30, 2023

Conversation

SinergiaCRM
Copy link
Contributor

Closes #9412

Description

Adding false to the second parameter when calling the function setValueClose(). Replacing line breaks in email field isn't necessary and it produces error.

Motivation and Context

Setting this parameter, it avoids displayed a wrong value

How To Test This

Follow the steps defined in the issue #9412

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

jack7anderson7
jack7anderson7 previously approved these changes Jan 8, 2022
@jack7anderson7 jack7anderson7 added the Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member label Jan 8, 2022
@clemente-raposo
Copy link
Contributor

@jack7anderson7 we should add Fix #9412 to the start of the commit message

@jack7anderson7
Copy link
Contributor

Hi @SinergiaCRM,

Could you update the commit message of this PR as you have done with others following: https://docs.suitecrm.com/community/contributing-code/bugs/#_providing_a_bug_fix

Thanks

@SinergiaCRM
Copy link
Contributor Author

Hi @SinergiaCRM,

Could you update the commit message of this PR as you have done with others following: https://docs.suitecrm.com/community/contributing-code/bugs/#_providing_a_bug_fix

Thanks

Done 👍

@SinergiaCRM SinergiaCRM changed the title Fixes #9412 - Wrong email value displayed when aborting an inline edition Fix #9412 - Wrong email value displayed when aborting an inline edition Feb 25, 2022
@SinergiaCRM SinergiaCRM changed the base branch from hotfix-7.10.x to hotfix February 25, 2022 05:21
@serhiisamko091184 serhiisamko091184 added Area: Clean Up: Performance Issues & PRs related to all things regarding to performance Status: Requires Code Review Needs the core team to code review PR 4-8 Score given to PRs once assessed labels Sep 18, 2023
@clemente-raposo clemente-raposo added Status: Requires Testing Requires Manual Testing Status: Passed Code Review Mark issue has passed code review reviewed and removed Status: Requires Code Review Needs the core team to code review labels Oct 11, 2023
@johnM2401 johnM2401 added Status: Passed Testing and removed Status: Requires Testing Requires Manual Testing labels Oct 13, 2023
@jack7anderson7 jack7anderson7 merged commit e0ce9a6 into salesagility:hotfix Oct 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Clean Up: Performance Issues & PRs related to all things regarding to performance PR 4-8 Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Passed Code Review Mark issue has passed code review reviewed Status: Passed Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Displayed value when aborting an Email inline edit
5 participants