Sort quote and invoice PDF templates by name #9444
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack7anderson7
previously approved these changes
Feb 8, 2022
jack7anderson7
added
the
Status:Assessed
jack7anderson7
force-pushed
the
fix/sortPdfTemplates
branch
2 times, most recently
from
b0e6921
to
0a62c1c
Compare
|
Hi @J-Light, I have changed the branch you are pointing to from Thanks, |
jack7anderson7
removed
the
Status:Assessed
jack7anderson7
added
Status:Assessed
jack7anderson7
approved these changes
Feb 8, 2022
jack7anderson7
added
the
Status: Requires Code Review
serhiisamko091184
added
the
Area: PDFs
jack7anderson7
force-pushed
the
fix/sortPdfTemplates
branch
from
0a62c1c
to
2c9e7a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PDF Template pop up results in an unordered list. Cases where several templates are defined, selecting them, forces users to read the complete list. An alphabetical sort is more logical easier to work with.
Motivation and Context
Improve the UX of users generating Quotes and Invoices by showing the list in alphabetical order.
How To Test This
Create several quote and invoice templates
Generate a quote and Invoice
Print to Pdf for both quote and invoice.
Verify that the template are in alphabetical order
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Final checklist
My code follows the code style of this project found here.
My change requires a change to the documentation.
I have read the How to Contribute guidelines.