Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #9594 - Don't convert nl to BR for contact updates #9597

Merged
merged 1 commit into from Jul 29, 2022
Merged

Fix #9594 - Don't convert nl to BR for contact updates #9597

merged 1 commit into from Jul 29, 2022

Conversation

JimMackin
Copy link
Contributor

Description

Case updates from contacts are run through nl2br which adds unexpected whitespace and causes #9594. This fix removes the call.

Motivation and Context

Fixes #9594

How To Test This

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@JimMackin
Fix salesagility#9594 - Don't convert nl to BR for contact updates as…
4764a26 
… these contain HTML and come from emails in most cases.
@jack7anderson7 jack7anderson7 added Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Branch:Hotfix labels Jul 25, 2022
clemente-raposo
clemente-raposo approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@clemente-raposo clemente-raposo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clemente-raposo clemente-raposo merged commit 563dfc9 into salesagility:hotfix Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemente-raposo clemente-raposo clemente-raposo approved these changes

@jack7anderson7 jack7anderson7 jack7anderson7 approved these changes

Assignees
No one assigned
Labels
Branch:Hotfix Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JimMackin @clemente-raposo @jack7anderson7