Fix #9654 - Fix issue with different date formats being compared for change log #9657
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call fixUpFormatting before comparing values for change/audit log
Description
Call fixUpFormatting before comparing values for change/audit log
Motivation and Context
getDataChanges(include/database/DBManager.php) will not fix formatting before comparing values.
Depending on functionality that could be added in save hook getDataChanges can potentially be comparing values with different formats. e.g. Save hook uses retrieve: $contact->retrieve($contact->id);
Dates returned using retrieve are set in user pref format: 22-07-2022
When passed into getDataChanges the date is compared against DB format: 2022-07-22
Although date are the same the change log believes they are different: 22-07-2022 !== 2022-07-22
How To Test This
Create aftersave hook
Set user pref date format to non-db format
Use retrieve on bean you are saving: $contact->retrieve($contact->id);
Check modules audit log for changes
Types of changes
Final checklist