Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9704 - Missing relationship definition in SurveysQuestionResponses #9705

Merged
merged 1 commit into from Oct 25, 2022

Conversation

SinergiaCRM
Copy link
Contributor

Description

This PR add the missing relationship in the vardef for the module SurveysQuestions

We also modify some invalid vname vardefs from the SurveyQuestionResponses module.

And add some missing labels for the SurveyQuestionOptions module.

Motivation and Context

This should be added to fix the issue

How To Test This

It can be validated by code inspections or, as described in the issue, using Kreporter third-party module.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@jack7anderson7 jack7anderson7 added Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Branch:Hotfix labels Sep 23, 2022
Copy link
Contributor

@clemente-raposo clemente-raposo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jack7anderson7 jack7anderson7 merged commit 07d07ff into salesagility:hotfix Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Branch:Hotfix Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants