Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9728 - cron.php fails with "must be compatible" error #9729

Merged
merged 1 commit into from Oct 25, 2022

Conversation

kgaillot
Copy link
Contributor

@kgaillot kgaillot commented Aug 5, 2022

… from AOPInboundEmail.php

Description

Trying to run cron.php with PHP 8 fails with a fatal error (see issue salesagility/SuiteCRM-Core#143):

PHP Fatal error:  Declaration of AOPInboundEmail::handleCreateCase(Email $email, $userId) must be compatible with InboundEmail::handleCreateCase($email, $userId)

Motivation and Context

This allows cron.php to succeed on a system with PHP 8.

The fix was suggested by pgr on forum team: "it’s a known issue that was aggravated in PHP 8 because it used to be a warning, now it’s FATAL"

How To Test This

Run cron.php with PHP 8

(Note: for the script to fully succeed, PR #9731 for Issue #9730 must also be applied)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@SuiteBot
Copy link

SuiteBot commented Aug 5, 2022

CLA assistant check
All committers have signed the CLA.

@SuiteBot
Copy link

SuiteBot commented Aug 5, 2022

This pull request has been mentioned on SuiteCRM. There might be relevant details there:

https://community.suitecrm.com/t/patches-needed-for-cron-script/85841/3

@jack7anderson7 jack7anderson7 added Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Branch:Hotfix labels Sep 23, 2022
Copy link
Contributor

@clemente-raposo clemente-raposo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jack7anderson7 jack7anderson7 merged commit 0141f30 into salesagility:hotfix Oct 25, 2022
@SuiteBot
Copy link

This pull request has been mentioned on SuiteCRM. There might be relevant details there:

https://community.suitecrm.com/t/declaration-of-aopinboundemail-error/87050/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Branch:Hotfix Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants