Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elasticsearch Module Filter #9734

Closed
wants to merge 2 commits into from
Closed

Elasticsearch Module Filter #9734

wants to merge 2 commits into from

Conversation

MikeyJC
Copy link
Contributor

@MikeyJC MikeyJC commented Aug 9, 2022

Description

Adds a module filter select to the Elasticsearch global search view. The dropdown will be generated to include all the searchable modules, and when a module is selected and the search run, only results that include that module will be returned.

Motivation and Context

This allows quicker searches for more relevant results for the user.

How To Test This

  1. Navigate to the global search view.
  2. Select any of the modules in the dropdown.
  3. Run the search on your query, with the new module filter.
  4. Check returned results.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@MikeyJC MikeyJC force-pushed the feature/elasticsearch_module_search branch from 99bf9ea to 89d7ac6 Compare December 15, 2022 14:49
@MikeyJC MikeyJC marked this pull request as ready for review December 15, 2022 14:51
@jack7anderson7 jack7anderson7 force-pushed the feature/elasticsearch_module_search branch from 89d7ac6 to aeaaf54 Compare March 17, 2023 10:14
@jack7anderson7 jack7anderson7 changed the base branch from hotfix to hotfix-7.13.x March 17, 2023 10:15
@jack7anderson7 jack7anderson7 added Status: Requires Code Review Needs the core team to code review Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member labels Mar 17, 2023
@clemente-raposo
Copy link
Contributor

Hi @jack7anderson7, shouldn't this be pointing to hotfix?

@clemente-raposo clemente-raposo added Status:Requires Updates Issues & PRs which requires input or update from the author Status:In Review Pull Requests that are activity being reviewed by the core team labels Mar 20, 2023
@jack7anderson7 jack7anderson7 added the Area: Elasticsearch Issues & PRs related to all things regarding Elasticsearch label Sep 8, 2023
@serhiisamko091184 serhiisamko091184 mentioned this pull request May 9, 2024
Open
5 tasks
@serhiisamko091184 serhiisamko091184 removed Status:Requires Updates Issues & PRs which requires input or update from the author Status:In Review Pull Requests that are activity being reviewed by the core team labels May 9, 2024
@serhiisamko091184
Copy link
Contributor

Hello @MikeyJC,

thanks for contributing, recreated this PR:
#10423

Regards,
Serhii

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Elasticsearch Issues & PRs related to all things regarding Elasticsearch Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Requires Code Review Needs the core team to code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MikeyJC @clemente-raposo @serhiisamko091184 @jack7anderson7